BUG: concat sorting when sort=False for all dti #51683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine, haven't looked closely. Bug me about it next week. |
|
This one isn't urgent |
jbrockmendel
reviewed
Mar 7, 2023
# Conflicts: # doc/source/whatsnew/v2.1.0.rst
mroeschke
reviewed
Mar 8, 2023
| @@ -280,7 +280,6 @@ def _find_common_index_dtype(inds): | |||
| raise TypeError("Cannot join tz-naive with tz-aware DatetimeIndex") | |||
|
|
|||
| if len(dtis) == len(indexes): | |||
| sort = True | |||
There was a problem hiding this comment.
I wonder if the sort = False below also causes a similar issue
There was a problem hiding this comment.
Based on the comment it looks like this is necessary, but yes this probably causes trouble as well
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Feel free to reopen if/when you have the time to circle back |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.lets see if this passes everything