-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Support na_position for sort_index and sortlevel #51672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @phofl |
level=None, | ||
ascending: bool | list[bool] = True, | ||
sort_remaining=None, | ||
na_position: str_t = "first", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phofl - any reason to default to first here? With a quick grep I'm seeing we default to last everywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure that this was done for backwards compatibility reasons. Does this break anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope - makes sense. I'll experiment with changing the default and see what breaks; depending on that may put up an issue to deprecate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections to deprecate. IIRC this is used internally a bunch, so deprecating might be tricky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - I meant just deprecating the default and changing it to "last" to be consistent with other sorting methods. We can still specify "first" internally so hopefully it will be straight forward unless I'm missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah got you. No that makes sense
na_position
ignored when sortingMultiIndex
withlevel!=None
#51612 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I think the special casing in sort level was done for performance reason. Avoiding the use of categorical solves this. Both branches were equally fast