-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WEB: Added stying for pre element within the codeblock divs #51665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsamuel27
commented
Feb 27, 2023
•
edited
Loading
edited
- closes #WEB: Improve the style of the code boxes in the website #51657 (Replace xxxx with the GitHub issue number)
- ENH: Enhancement, adding styling (padding and border) for code blocks
I was reviewing the stylesheets. Would you rather have me add the new styling to codehilite.css since it's effecting the codehilite class? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @dsamuel27, I had a look at the rendered version and looks great.
I was reviewing the stylesheets. Would you rather have me add the new styling to codehilite.css since it's effecting the codehilite class?
I guess it's a more natural place to be, yes. @lithomas1 do you want to have a look here?
I ended up moving the css code to codehilite.css |
Great, probably better. I'll someone else from the core dev team have a second look and merge, otherwise I'll merge myself in couple of days. But this should be good to go. |
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/51665/ |
An example of where the changes can be seen is here: https://pandas.pydata.org/preview/51665/pdeps/0004-consistent-to-datetime-parsing.html |
Thanks @dsamuel27, very nice! |