Skip to content

WEB: Added stying for pre element within the codeblock divs #51665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

dsamuel27
Copy link
Contributor

@dsamuel27 dsamuel27 commented Feb 27, 2023

@dsamuel27
Copy link
Contributor Author

dsamuel27 commented Feb 27, 2023

I was reviewing the stylesheets. Would you rather have me add the new styling to codehilite.css since it's effecting the codehilite class?

@phofl phofl requested a review from datapythonista February 27, 2023 10:53
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @dsamuel27, I had a look at the rendered version and looks great.

I was reviewing the stylesheets. Would you rather have me add the new styling to codehilite.css since it's effecting the codehilite class?

I guess it's a more natural place to be, yes. @lithomas1 do you want to have a look here?

@datapythonista datapythonista changed the title Added stying for pre element within the codeblock divs WEB: Added stying for pre element within the codeblock divs Feb 27, 2023
@datapythonista datapythonista added the Web pandas website label Feb 27, 2023
@dsamuel27
Copy link
Contributor Author

I ended up moving the css code to codehilite.css

@datapythonista
Copy link
Member

I ended up moving the css code to codehilite.css

Great, probably better. I'll someone else from the core dev team have a second look and merge, otherwise I'll merge myself in couple of days. But this should be good to go.

@datapythonista
Copy link
Member

/preview

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Website preview of this PR available at: https://pandas.pydata.org/preview/51665/

@datapythonista
Copy link
Member

Website preview of this PR available at: https://pandas.pydata.org/preview/51665/

An example of where the changes can be seen is here: https://pandas.pydata.org/preview/51665/pdeps/0004-consistent-to-datetime-parsing.html

@datapythonista datapythonista merged commit f9be5d9 into pandas-dev:main Mar 7, 2023
@datapythonista
Copy link
Member

Thanks @dsamuel27, very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web pandas website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants