Skip to content

BUG: Change default of group_keys to True #51627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

I think this was missed because no_default is truthy.

@rhshadrach rhshadrach added Groupby Apply Apply, Aggregate, Transform, Map Bug labels Feb 25, 2023
@rhshadrach rhshadrach added this to the 2.0 milestone Feb 25, 2023
@phofl phofl merged commit cb2336e into pandas-dev:main Feb 25, 2023
@phofl
Copy link
Member

phofl commented Feb 25, 2023

thx @rhshadrach

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 25, 2023
@rhshadrach rhshadrach deleted the group_keys_default branch February 25, 2023 15:44
phofl pushed a commit that referenced this pull request Feb 25, 2023
… to True) (#51632)

Backport PR #51627: BUG: Change default of group_keys to True

Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Bug Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants