PERF: maybe_promote #51592
Merged
PERF: maybe_promote #51592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Performance
jbrockmendel
force-pushed
the
perf-maybe_promote
branch
from
cb0fcae to
5379298
Compare
mroeschke
reviewed
Feb 24, 2023
| @@ -556,6 +557,13 @@ def ensure_dtype_can_hold_na(dtype: DtypeObj) -> DtypeObj: | |||
| return dtype | |||
|
|
|||
|
|
|||
| _canonical_nans = { | |||
| np.datetime64: np.datetime64("NaT", "ns"), | |||
There was a problem hiding this comment.
Will it always be correct to assume "ns"?
There was a problem hiding this comment.
in most contexts it wont matter, but we could probably cook up an example (maybe with object dtype) where it did
There was a problem hiding this comment.
updated so as to retain identical fill_value in object-result cases
|
our asv site appears to be done, but locally a lot of the regressions im seeing since 1.5.0 are for cc @phofl |
phofl
reviewed
Mar 2, 2023
phofl
approved these changes
Mar 2, 2023
|
thx @jbrockmendel |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 2, 2023
phofl
pushed a commit
that referenced
this pull request
Mar 2, 2023
Backport PR #51592: PERF: maybe_promote Co-authored-by: jbrockmendel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test runtime for pandas/tests/indexing/multiindex/test_indexing_slow.py decreases from 30s to 14.5s.
See discussion around #39692 (comment)