Skip to content

BUG: not broadcasting when setting empty object #51585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 23, 2023

This is a regression on 1.5.x that we could get rid of because of changes since then. Should go into 2.0 instead of 1.5.x

@simonjayhawkins
Copy link
Member

This is a regression on 1.5.x that we could get rid of because of changes since then. Should go into 2.0 instead of 1.5.x

can you expand a bit on this

@simonjayhawkins simonjayhawkins added the Regression Functionality that used to work in a prior pandas version label Feb 23, 2023
@phofl
Copy link
Member Author

phofl commented Feb 23, 2023

I tried removing the condition as I did here on 1.5.x and this does not work. Not overly interested in making an even more complex condition to accommodate all possible special cases on 1.5.x

@phofl phofl added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 23, 2023
@simonjayhawkins
Copy link
Member

ok. The issue hasn't been triaged. Maybe worth commenting there.

@phofl phofl added this to the 2.0 milestone Feb 23, 2023
@mroeschke mroeschke merged commit ddb19e2 into pandas-dev:main Feb 24, 2023
@mroeschke
Copy link
Member

Thanks @phofl

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 24, 2023
mroeschke pushed a commit that referenced this pull request Feb 24, 2023
…g empty object) (#51618)

Backport PR #51585: BUG: not broadcasting when setting empty object

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the 51450 branch August 28, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: loc setitem fails with shape mismatch
3 participants