Skip to content

Revert "REF: de-duplicate precision_from_unit" #51584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2023
Merged

Revert "REF: de-duplicate precision_from_unit" #51584

merged 2 commits into from
Feb 23, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 23, 2023

Reverts #51483

@simonjayhawkins simonjayhawkins added the Refactor Internal refactoring of code label Feb 23, 2023
@simonjayhawkins simonjayhawkins added this to the 2.1 milestone Feb 23, 2023
MarcoGorelli
MarcoGorelli approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl

precision_from_unit would need to propagate the error

@MarcoGorelli MarcoGorelli merged commit 887d2c4 into main Feb 23, 2023
@phofl phofl deleted the revert-51483-ref-precision_from_unit branch February 23, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @MarcoGorelli @simonjayhawkins