BUG: transpose inferring dtype for dt in object column #51565
Conversation
| @@ -63,7 +65,7 @@ def test_transpose_tzaware_2col_mixed_tz(self): | |||
| df4 = DataFrame({"A": dti, "B": dti2}) | |||
| assert (df4.dtypes == [dti.dtype, dti2.dtype]).all() | |||
| assert (df4.T.dtypes == object).all() | |||
| tm.assert_frame_equal(df4.T.T, df4) | |||
| tm.assert_frame_equal(df4.T.T, df4, check_dtype=False) | |||
There was a problem hiding this comment.
can you cast the expected here to keep the test strict
| @@ -464,7 +464,7 @@ def test_groupby_quantile_dt64tz_period(): | |||
|
|
|||
| # Check that we match the group-by-group result | |||
| exp = {i: df.iloc[i::5].quantile(0.5) for i in range(5)} | |||
| expected = DataFrame(exp).T | |||
| expected = DataFrame([x.tolist() for x in exp.values()], index=exp.keys()) | |||
There was a problem hiding this comment.
could do .infer_objects()?
no strong preference. i think we're doing more still-merging-to-2.0 in the RC this time around than we usually do, not sure how much is too much |
|
Then lets do for 2.1, no strong preference either on my side |
phofl
added
Dtype Conversions
pandas/conftest.py
Outdated
| @@ -1919,6 +1919,7 @@ def using_copy_on_write() -> bool: | |||
| """ | |||
| Fixture to check if Copy-on-Write is enabled. | |||
| """ | |||
| pd.options.mode.copy_on_write = True | |||
There was a problem hiding this comment.
Nope thx, already removed. Snuck in
| result = self._constructor(new_arr, index=self.columns, columns=self.index) | ||
| result = self._constructor( | ||
| new_arr, index=self.columns, columns=self.index, dtype=new_arr.dtype | ||
| ) |
There was a problem hiding this comment.
do we need to pass copy=False here (possibly just to be future-safe)?
There was a problem hiding this comment.
Yep, I’ll add it in the copy=True pr.
actually, it probably makes sense to go through all usages of constructor and pass copy=False for arrays. Will take a look how many there are
|
thanks @phofl |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel thoughts about doing it for 2.0 or 2.1?