TST: Add test for groupby rename categories with multiIndexes #51555
Conversation
| @pytest.mark.parametrize("op", ["add", "sub", "mul", "div"]) | ||
| def test_groupyby_rename_categories_operation_with_multiindex(op): | ||
| # 51500 | ||
| data = DataFrame( |
There was a problem hiding this comment.
This is too complicated. First step is to figure out what changed and fixed the bug. Afterwards, we want a dedicated test for this operation
There was a problem hiding this comment.
I have to admit that finding bugs that have been fixed is difficult.
However, I searched the entire test folder and there doesn't seem to be a test written for groupyby along with rename_categories. I would like to add some simpler test cases to test that the behavior between their two methods is as expected. @phofl any suggestions?
There was a problem hiding this comment.
I don't think that testing this is necessary. If rename_categories provides a value Categorical, this should work as expected. I'd suggest going back to a version where the test was failing
There was a problem hiding this comment.
After comparing the buggy version and the main branch, I noticed that the results from the groupby may differ between the two versions, which in turn led to a series of subsequent issues.
In my opinion, this pull request can be closed because the test cases added to fix the previous bug appear to be complete.
simonjayhawkins
added
the
Testing
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.