Skip to content

BUG: parsing pyarrow dtypes corner case #51548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 22, 2023

pretty dumb corner case

@phofl phofl added the Arrow pyarrow functionality label Feb 22, 2023
@phofl phofl added this to the 2.0 milestone Feb 22, 2023
@simonjayhawkins
Copy link
Member

release note? I think also should now target 2.1 now that rc is cut as this is not a 2.0.x regression or bugfix for a new feature.

@phofl
Copy link
Member

phofl commented Feb 22, 2023

Arrow support is more or less new, I think we can backport relevant fixes there

@simonjayhawkins
Copy link
Member

wasn't pd.ArrowDtype was added in 1.5?

@phofl
Copy link
Member

phofl commented Feb 22, 2023

Yes, but support was very limited for arrow stuff in 1.5

@simonjayhawkins
Copy link
Member

sure. it is experimental and this is not a big change so no objections to targeting 2.0

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged main once more but good for 2.0 IMO

@phofl phofl merged commit b070d87 into pandas-dev:main Feb 23, 2023
@phofl
Copy link
Member

phofl commented Feb 23, 2023

thx @jbrockmendel

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 23, 2023
@jbrockmendel jbrockmendel deleted the bug-51225 branch February 24, 2023 01:01
mroeschke pushed a commit that referenced this pull request Feb 24, 2023
…r case) (#51606)

Backport PR #51548: BUG: parsing pyarrow dtypes corner case

Co-authored-by: jbrockmendel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: dtype="int64[pyarrow]foobar[pyarrow]" fails to raise
4 participants