PERF: assert_index_equal with MultiIndex #51544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
approved these changes
Feb 22, 2023
phofl
added
Testing
phofl
reviewed
Feb 22, 2023
| @@ -558,6 +558,8 @@ def test_union_with_missing_values_on_both_sides(nulls_fixture): | |||
| mi2 = MultiIndex.from_arrays([[1, nulls_fixture, 3]]) | |||
| result = mi1.union(mi2) | |||
| expected = MultiIndex.from_arrays([[1, 3, nulls_fixture]]) | |||
| # We don't particularly care about having levels[0] be float64, but it is | |||
| expected = expected.set_levels([expected.levels[0].astype(np.float64)]) | |||
There was a problem hiding this comment.
This looks like a bug in union, more specifically midx.append
There was a problem hiding this comment.
agreed. i think i looked it at that for unrelated reasons a while back and didn't get anywhere.
|
thx @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_indexer_caching takes 10.09s on main, 2.92 with this branch.