Skip to content

TYP: Use Self for type checking (remaining locations) #51524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

topper-123
Copy link
Contributor

Follow-up to #51480, #51493 & #51493. After these 4 PRs, #51233 can be closed.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Feb 21, 2023
@simonjayhawkins simonjayhawkins added this to the 2.1 milestone Feb 21, 2023
@simonjayhawkins simonjayhawkins marked this pull request as draft February 24, 2023 15:19
.startup.ipy Outdated
@@ -0,0 +1,48 @@
>>> from itertools import product
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, didn't catch this comment. This was a mistake, was a file i ran on ipython startup related to another PR. It has been removed in the newest version.

@topper-123 topper-123 force-pushed the use_typing.Self_III branch from 919a85d to 3620d66 Compare March 13, 2023 21:51
@topper-123 topper-123 marked this pull request as ready for review March 14, 2023 06:05
@mroeschke mroeschke merged commit 3161e3f into pandas-dev:main Mar 14, 2023
@mroeschke
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the use_typing.Self_III branch March 14, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TYP: use Self for type checking
5 participants