PERF: maybe_convert_objects convert_numeric=False #51517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe merge? Can't remember anymore either |
|
Explode? |
|
Ah explode might be the culprit, yes |
|
couple of failing tests |
phofl
approved these changes
Feb 25, 2023
|
thx @jbrockmendel (accidentally pressed the wrong button...) Lets see how this changes our asvs, if we see a regression fix then can backport? |
|
works for me |
|
Looks like it's worth backporting https://asv-runner.github.io/asv-collection/pandas/#reshape.Explode.time_explode |
|
@meeseeksdev backport 2.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 27, 2023
lithomas1
pushed a commit
that referenced
this pull request
Feb 27, 2023
…rt_numeric=False) (#51661) Backport PR #51517: PERF: maybe_convert_objects convert_numeric=False Co-authored-by: jbrockmendel <[email protected]> Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes a perf regression that @phofl pinged me about a few weeks/months ago, but I forget the details.