Skip to content

CLN: Reset global config state in tests #51506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

CLN: Reset global config state in tests #51506

merged 3 commits into from
Feb 21, 2023

Conversation

mroeschke
Copy link
Member

Found in #51496

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Clean labels Feb 20, 2023
phofl
phofl approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, general comment: You could add a fixture that resets all options (not sure if this would be helpful here)

@phofl phofl added this to the 2.1 milestone Feb 20, 2023
@mroeschke
Copy link
Member Author

Added a fixture that will reset the global option on each test in the file. Hopefully users will reset the option in more of their tests...

@mroeschke mroeschke merged commit b1ba308 into pandas-dev:main Feb 21, 2023
@mroeschke mroeschke deleted the tst/option/state_clear branch February 21, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl