TYP: Use Self instead of class-bound TypeVar II (pandas/core/arrays/) #51497
+136
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
topper-123
force-pushed
the
use_typing.Self_II
branch
from
87f9e6a to
6bc954a
Compare
twoertwein
reviewed
Mar 14, 2023
| def _concat_same_type( | ||
| cls: type[IntervalArrayT], to_concat: Sequence[IntervalArrayT] | ||
| ) -> IntervalArrayT: | ||
| def _concat_same_type(cls, to_concat: Sequence[IntervalArray]) -> Self: |
There was a problem hiding this comment.
When I read the code, I see that to_concat can hold different subclasses of IntervalArray than self (probably unusual to subclass IntervalArray, but the type system allows it).
twoertwein
approved these changes
Mar 14, 2023
|
Thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #51233.
Follow-up to #51493, in this PR I do
pandas/core/arrays/.