REF: stricter typing in Manager.take #51478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Feb 18, 2023
| @@ -3915,6 +3916,11 @@ def _take( | |||
| and is_range_indexer(indices, len(self)) | |||
| ): | |||
| return self.copy(deep=None) | |||
| else: | |||
| # We can get here with a slice via DataFrame.__geittem__ | |||
There was a problem hiding this comment.
Typo in getitem
Is this a column or row-based slice?
There was a problem hiding this comment.
mind if i add the typo fix to my next Assorted CLN branch?
There was a problem hiding this comment.
id like to add a check for slice in __getitem__ before we get here to return self._slice(indexer) instead, but that may (probably should) cause us to return a view instead of copy.
Once that is changed, I'd like to deprecate allowing slice in DataFrame.take (which we don't allow in Series.take). It isn't documented, but still.
There was a problem hiding this comment.
Yeah fine by me.
Take returns a view for CoW even if it’s not a slice iirc. deprecating sounds good though.
phofl
approved these changes
Feb 19, 2023
phofl
added
Refactor
|
thx @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the slice case at at the ndframe level; in future passes I'd like to avoid allowing slices in .take altogether.