ERR: Improve error message in validate_percentile #51475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Feb 20, 2023
phofl
changed the title
simonjayhawkins
added
the
Error Reporting
phofl
requested changes
Mar 14, 2023
|
I apologize for the mistake I made earlier. |
phofl
reviewed
Mar 16, 2023
pandas/tests/util/test_validator.py
Outdated
| percentile_array = [-0.5, 0.25, 1.5] | ||
| msg = "percentiles should all be in the interval \\[0, 1\\]" | ||
| with pytest.raises(ValueError, match=msg): | ||
| s.quantile(percentile_array) |
There was a problem hiding this comment.
There is a file for quantile tests
There was a problem hiding this comment.
The pandas/tests/frame/methods/test_quantile.py one ?
phofl
reviewed
Mar 25, 2023
| msg = "percentiles should all be in the interval \\[0, 1\\]" | ||
| for invalid in [-1, 2, [0.5, -1], [0.5, 2]]: |
There was a problem hiding this comment.
@phofl Do I need append the Series test ?
Something like :-
msg = "percentiles should all be in the interval \\[0, 1\\]"
for invalid in [-1, 2, [0.5, -1], [0.5, 2]]:
with pytest.raises(ValueError, match=msg):
datetime_series.quantile(invalid)
s = Series(np.random.randn(100))
percentile_array = [-0.5, 0.25, 1.5]
with pytest.raises(ValueError, match=msg):
s.quantile(percentile_array)
|
@phofl, Is this ok? |
phofl
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR improves the validation of percentiles in pandas. Previously, when an out-of-range value was detected, the code would suggest a wrong value. This suggestion could be confusing to users and was not always necessary. This PR simplifies the suggestion message to directly state that the value should be between 0 and 1.