Skip to content

DEPS: Partial Matplotlib 3.7 support #51470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2023
Merged

Conversation

mroeschke
Copy link
Member

xref #51394

These pass locally with 3.7, the remaining issue will be address with matplotlib/matplotlib#25219

@mroeschke mroeschke added Visualization plotting Dependencies Required and optional dependencies labels Feb 17, 2023
@ksunden
Copy link

ksunden commented Feb 17, 2023

You may have to do version checks for legend_handles vs legendHandles if you don't want to pin to mpl3.7, the snake case version is new, but is preferred going forward, the camel case version was not actually meant to be fully public (it wasn't documented, but it also didn't have an _, so it got used)

@phofl phofl added this to the 2.0 milestone Feb 20, 2023
@phofl phofl merged commit 9a71cdb into pandas-dev:main Feb 20, 2023
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 20, 2023
@phofl
Copy link
Member

phofl commented Feb 20, 2023

thx @mroeschke

I think we should backport, feel free to close the pr if you think differently

@mroeschke
Copy link
Member Author

Agreed would be worth backporting

@mroeschke mroeschke deleted the deps/mpl/37 branch February 20, 2023 22:05
phofl added a commit that referenced this pull request Feb 21, 2023
…ort) (#51510)

Backport PR #51470: DEPS: Partial Matplotlib 3.7 support

Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants