TST: un-xfail NaT test on npdev #51455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 17, 2023
Co-authored-by: Matthew Roeschke <[email protected]>
jbrockmendel
commented
Feb 17, 2023
| # GH 26039 | ||
| opname = compare_operators_no_eq_ne | ||
| if isinstance(other, (np.datetime64, np.timedelta64)) and ( | ||
| opname in ["__eq__", "__ne__"] or not is_numpy_dev |
There was a problem hiding this comment.
looks like the eq/ne checks here are unnecessary. ill clean it up in a follow-up so we can get the CI back to green quickly.
mroeschke
added
the
Testing
mroeschke
approved these changes
Feb 17, 2023
|
npdev is green, the failing test is an unrelated file leak. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.