Skip to content

REF: simplify python_agg_general #51447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

REF: simplify python_agg_general #51447

merged 1 commit into from
Feb 17, 2023

Conversation

jbrockmendel
Copy link
Member

cc @rhshadrach

I hypothesize that we can further simplify DFGB._python_agg_general, part of which will come after #51398.

@mroeschke mroeschke requested a review from rhshadrach February 17, 2023 18:37
@mroeschke mroeschke added Refactor Internal refactoring of code Groupby labels Feb 17, 2023
@rhshadrach rhshadrach added this to the 2.0 milestone Feb 17, 2023
rhshadrach
rhshadrach approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; failures are unrelated.

@rhshadrach rhshadrach merged commit bab4f30 into pandas-dev:main Feb 17, 2023
@rhshadrach
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-_python_agg_general branch February 17, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @rhshadrach @mroeschke