Skip to content

DOC Fix EX01 issues in docstrings #51440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Conversation

DeaMariaLeon
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Towards #37875

@mroeschke mroeschke added the Docs label Feb 16, 2023
@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Feb 17, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @DeaMariaLeon !

Leaving open for a bit in case others have comments, then will merge

Examples
--------
>>> period = pd.Period('2023-1-1', freq='D')
>>> period = period.to_timestamp()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use a different name here since it is no longer a period?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done..
I also added to the DataFrame.to_timestamp example, to show the use of freq.

Merge remote-tracking branch 'upstream/main' into examples
Merge remote-tracking branch 'upstream/main' into examples
Merge remote-tracking branch 'origin/examples' into examples
@mroeschke mroeschke merged commit a162c40 into pandas-dev:main Feb 17, 2023
@mroeschke
Copy link
Member

Thanks @DeaMariaLeon

@DeaMariaLeon DeaMariaLeon deleted the examples branch February 20, 2023 08:17
@DeaMariaLeon
Copy link
Member Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants