TST: clip inplace doesn't modify views with CoW #51402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
the
Testing
phofl
reviewed
Feb 15, 2023
| view = df[:] | ||
| df.clip(lower=2, inplace=True) | ||
|
|
||
| # Clip not actually inplace right now but could be |
There was a problem hiding this comment.
Ah no, could you add another test without a reference? I think it should pass after my where pr is in
There was a problem hiding this comment.
I think it is not actually inplace even without CoW.
There was a problem hiding this comment.
Yep you are correct. We should refactor this if we decide to keep inplace here
phofl
approved these changes
Feb 15, 2023
|
thx @lithomas1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.