Skip to content

CLN: Simplify agg_list_like #51396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

CLN: Simplify agg_list_like #51396

merged 1 commit into from
Feb 15, 2023

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This logic was added in #41017 to deal with partial failure that can no longer occur.

@rhshadrach rhshadrach added Clean Apply Apply, Aggregate, Transform, Map Reduction Operations sum, mean, min, max, etc. labels Feb 15, 2023
jbrockmendel
jbrockmendel approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending greenish

@mroeschke mroeschke added this to the 2.0 milestone Feb 15, 2023
@mroeschke mroeschke merged commit 8a40960 into pandas-dev:main Feb 15, 2023
@mroeschke
Copy link
Member

Thanks @rhshadrach (failures unrelated)

@rhshadrach rhshadrach deleted the agg_list_like_no_fail branch February 15, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Clean Reduction Operations sum, mean, min, max, etc.
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rhshadrach @mroeschke @jbrockmendel