Skip to content

DOC: clarify pitfalls of NA vs NaN in nullable floats #51383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

DOC: clarify pitfalls of NA vs NaN in nullable floats #51383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24008fa
add note to docstring re NA vs NaN
a-reich Feb 14, 2023
ead6e86
revise docstring per feedback
a-reich Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7873,6 +7873,12 @@ def isna(self: NDFrameT) -> NDFrameT:
strings ``''`` or :attr:`numpy.inf` are not considered NA values
(unless you set ``pandas.options.mode.use_inf_as_na = True``).

Note: For nullable float extension dtypes, i.e.
``Float<...>`` and ``float<...>[pyarrow]``, the behavior is different -
missing data is designated by ``pandas.NA`` values while NaN may also be
stored but will **not** get mapped to True (these values can be detected
by :func:`numpy.isnan`).
Comment on lines +7879 to +7880
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe s.map(pd.isna) or df.map(pd.isna) is a better suggestion?


Returns
-------
{klass}
Expand Down