ENH: Add lazy copy to where #51336
Merged
ENH: Add lazy copy to where #51336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
approved these changes
Feb 14, 2023
|
|
||
|
|
||
| @pytest.mark.parametrize("dtype", ["int64", "Int64"]) | ||
| def test_where_noop(using_copy_on_write, dtype): |
There was a problem hiding this comment.
I suppose you put it intentionally in test_indexing.py instead of test_methods.py?
Personally I would still put it in test_methods.py, although it is an indexing like method, everything in this file are actual indexing operations.
There was a problem hiding this comment.
Yeah was intentional, but ok to move over. We will have to split them up anyway. Wanted to tackle this after 2.0
73 tasks
|
It seems there is an actual relevant test failure with CoW: FAILED pandas/tests/frame/indexing/test_where.py::test_where_copies_with_noop[Series] - AssertionError: Series are different |
|
Will rebase after the other pr is merged |
|
thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.