DOC: clarify "inplace"-ness of DataFrame.setitem #51328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
changed the title
There was a problem hiding this comment.
@loicdiridollou thanks a lot for the PR! I think the general wording is good, I just added a few tiny comments.
pandas/core/frame.py
Outdated
| ``frame.isetimtem(loc, value)`` is an in-place method as it will | ||
| modify the frame in place (not returning a new object) but it will | ||
| not update the values of the column itself, it will instead insert | ||
| a new array. |
There was a problem hiding this comment.
I would add something like "in contrast to frame.iloc[:, i] = value which will try to update the existing values inplace"
There was a problem hiding this comment.
I just made some examples on my side and indeed this is quite important to keep that in the docs, I will update that
There was a problem hiding this comment.
We should be good now, let me know if the phrasing is clear enough
There was a problem hiding this comment.
We should be good now, let me know if the phrasing is clear enough
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
jorisvandenbossche
approved these changes
Feb 14, 2023
phofl
approved these changes
Feb 20, 2023
|
thx @loicdiridollou lets backport, this is nice to have for CoW |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 20, 2023
phofl
added a commit
that referenced
this pull request
Feb 21, 2023
…taFrame.setitem) (#51512) Backport PR #51328: DOC: clarify "inplace"-ness of DataFrame.setitem Co-authored-by: Loic Diridollou <[email protected]> Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.