Skip to content

ENH: Avoid copy when possible in merge #51327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 11, 2023

Technically this would change the behavior for the non CoW case with copy=False as well

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jorisvandenbossche
Copy link
Member

Failure in the CoW build is the unrelated test_file_descriptor_leak

@jorisvandenbossche jorisvandenbossche added this to the 2.0 milestone Feb 14, 2023
@jorisvandenbossche jorisvandenbossche merged commit 8d1b7fc into pandas-dev:main Feb 14, 2023
@phofl phofl deleted the cow_merge branch February 14, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants