CI/TST: Enable -W error:::pandas in pyproject.toml #51312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
mroeschke
commented
Feb 16, 2023
| @@ -632,36 +632,9 @@ def read_sql( | |||
| >>> pd.read_sql('test_data', 'postgres:///db_name') # doctest:+SKIP | |||
|
|
|||
| Apply date parsing to columns through the ``parse_dates`` argument | |||
|
|
|||
| >>> pd.read_sql('SELECT int_column, date_column FROM test_data', | |||
There was a problem hiding this comment.
I removed these examples because they trigger UserWarnings that the format could not be inferred. There is still an example of parse_dates at the bottom that I think fits the spirit of showing what the keyword does
| @@ -395,6 +395,9 @@ doctest_optionflags = [ | |||
| "ELLIPSIS", | |||
| ] | |||
| filterwarnings = [ | |||
| "error:::pandas", | |||
There was a problem hiding this comment.
If any unhanded warning with any message or warning class originates from the path pandas/*, treat it as as an error in the test suite.
Any subsequent filter in this list takes prescient over this one if they overlap.
|
needs a rebase |
|
Rebased. Added back the |
phofl
approved these changes
Feb 22, 2023
|
thx @mroeschke |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Feb 22, 2023
simonjayhawkins
pushed a commit
that referenced
this pull request
Feb 23, 2023
…in pyproject.toml) (#51570) Backport PR #51312: CI/TST: Enable -W error:::pandas in pyproject.toml Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-W error:::pandasin pytest during CI runs #48553 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.