BUG: idxmax and idxmin raising for all na ea series #51305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
NA - MaskedArrays
|
xref #33941 |
|
why closing? i was looking forward to getting #33941 resolved (i think it has implications for fixing some of our groupby xfails) |
|
Did not look like there was consensus and we had tests covering the changed behavior. But can revisit if you think we should change it |
|
Let's try to discuss the desired behavior here on the next dev call? I think this is an area where we need to Just Make A Decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Not sure if NA or NaN makes more sense. I think we have a couple of ops where we return nan even for ea dtypes when the result is a scalar