Skip to content

ENH: Do unique check before computing indexer in reindex #51304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2023
Merged

ENH: Do unique check before computing indexer in reindex #51304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4972aff
ENH: Do unique check before computing indexer in reindex
phofl Feb 10, 2023
f6c5a54
Refactor
phofl Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4217,17 +4217,11 @@ def reindex(
)
elif self._is_multi:
raise ValueError("cannot handle a non-unique multi-index!")
else:
if method is not None or limit is not None:
raise ValueError(
"cannot reindex a non-unique index "
"with a method or limit"
)
indexer, _ = self.get_indexer_non_unique(target)

if not self.is_unique:
elif not self.is_unique:
# GH#42568
raise ValueError("cannot reindex on an axis with duplicate labels")
else:
indexer, _ = self.get_indexer_non_unique(target)

target = self._wrap_reindex_result(target, indexer, preserve_names)
return target, indexer
Expand Down