TST: add CoW test for setitem with Series being set #51296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 tasks
phofl
reviewed
Feb 10, 2023
| df.isetitem(1, ser) # This is inplace | ||
|
|
||
| ser.loc[0] = 0 | ||
| expected = df = DataFrame({"a": [7, 8, 9], "b": np.array([4, 5, 6], dtype=dtype)}) |
There was a problem hiding this comment.
I think you want to remove df here?
|
The comment in the test was a left-over from copying the previous setitem test, will remove. But the docstring is actually confusing here, because it is an inplace method in the sense that it is updating the object inplace (we listed this method in the "always inplace" bucket in the draft PDEP). It's only not inplace in the sense that it will not update values inplace. |
|
Yeah good point, a clarification would probably help |
phofl
approved these changes
Feb 10, 2023
|
Fixed a small typo/copy paste issue. otherwise good to merge on greenish |
phofl
approved these changes
Feb 11, 2023
|
failures were unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #49473
We already have a test for setitem from #50692, but that only handled setting an array (actually, does that copy the array?), and not setting with a pandas object for which we could use lazy copy mechanism.
This is only adding the test, we seem to actually do an eager copy, so room for optimization.