Skip to content

CI pre-commit autoupdate #51290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

MarcoGorelli
Copy link
Member

the automated one didn't run, maybe because the diff is too large?

this touches a lot of files, but it's mostly just black removing newlines

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Feb 10, 2023
@MarcoGorelli MarcoGorelli marked this pull request as draft February 10, 2023 12:02
@twoertwein
Copy link
Member

Could also upgrade autotyping to 23.2.0 (pyright as well but that will probably require some code changes).

@topper-123
Copy link
Contributor

topper-123 commented Feb 10, 2023

but it's mostly just black removing newlines

Is there anything else? I cab only see removal of newlines, but there are a lot, so may I'm missing something?

MarcoGorelli added 2 commits February 11, 2023 14:10
@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 11, 2023 16:10
@MarcoGorelli
Copy link
Member Author

Could also upgrade autotyping to 23.2.0 (pyright as well but that will probably require some code changes).

I tried this but got

IndexError: string index out of range

Failed to codemod /home/marcogorelli/pandas-dev/pandas/core/arrays/categorical.py

I'll see if this needs reporting to them

Is there anything else? I cab only see removal of newlines, but there are a lot, so may I'm missing something?

I don't think so, but perhaps let's keep that to a separate PR

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Feb 11, 2023
@MarcoGorelli
Copy link
Member Author

thanks for reviewing!

@MarcoGorelli MarcoGorelli merged commit 4bf16d2 into pandas-dev:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants