ENH: Add CoW optimization for fillna #51279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/source/whatsnew/v2.0.0.rst # pandas/core/internals/blocks.py # pandas/tests/copy_view/test_interp_fillna.py
pandas/core/internals/blocks.py
Outdated
| return nbs | ||
|
|
||
| if limit is not None: | ||
| mask[mask.cumsum(self.ndim - 1) > limit] = False | ||
|
|
||
| if inplace: | ||
| if using_cow and self.refs.has_reference(): | ||
| # TODO(CoW): If using_cow is implemented for putmask we can defer |
There was a problem hiding this comment.
I merged the putmask PR
jorisvandenbossche
approved these changes
Feb 10, 2023
73 tasks
|
failure unrelated (flaky test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.