-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Allow ArrowDtype(pa.string()) to be compatable with str accessor #51207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f8930b4
Remove __init__ import
mroeschke 0c31e1e
Add base class methods
mroeschke f8aa6e5
Adapt for groupby
mroeschke 092f58f
Start adding test pt 1
mroeschke 10ad912
Add more tests part 2
mroeschke 0ae2e1d
Test pt 3
mroeschke 37d0add
More tests
mroeschke 4e6d24e
finish tests
mroeschke 1444393
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke c74473f
xfail dask test due to moved path
mroeschke d7a463f
Add whatsnew
mroeschke bca214b
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke 62d2f58
Fix import
mroeschke 6455214
Define len
mroeschke 8808c88
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke b57f142
Address some comments
mroeschke 852920d
address more dask tests
mroeschke 53d2083
Revert groupby change
mroeschke 977b698
fix some tests
mroeschke 2014a06
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke 5bb7d2a
Typing
mroeschke 0d15998
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke 112e185
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke 8b82b1b
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke 5d7ff0c
Undo downstream changes
mroeschke 29a5cbb
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke a3f53fd
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke e24a3ea
Merge remote-tracking branch 'upstream/main' into enh/str/arrow
mroeschke 35e35e3
Improve error message
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see this is already in the string_arrow code, but why "//$"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, as you mentioned I just copied it over from the string_arrow code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Best guess is it should be backslashes, meant to exclude escaped dollar signs. OK to consider out of scope.