Skip to content

REF: consolidate numeric_only checks in GroupBy #51185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2023
Merged

REF: consolidate numeric_only checks in GroupBy #51185

merged 2 commits into from
Feb 6, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

rhshadrach
rhshadrach approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Refactor Internal refactoring of code Groupby Error Reporting Incorrect or improved errors from pandas labels Feb 6, 2023
@phofl phofl added this to the 2.0 milestone Feb 6, 2023
@phofl phofl merged commit 82ccccd into pandas-dev:main Feb 6, 2023
@phofl
Copy link
Member

phofl commented Feb 6, 2023

thx @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-get_data_to_aggregate branch February 6, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Groupby Refactor Internal refactoring of code
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @phofl @rhshadrach