API: remove Grouper.groups #51170
Closed
API: remove Grouper.groups #51170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
approved these changes
Feb 5, 2023
phofl
reviewed
Feb 5, 2023
| @@ -387,12 +386,6 @@ def _set_grouper(self, obj: NDFrame, sort: bool = False) -> None: | |||
| self.obj = obj # type: ignore[assignment] | |||
| self._gpr_index = ax | |||
|
|
|||
| @final | |||
There was a problem hiding this comment.
Ah approved to quickly. I have a question:
df = DataFrame({"a": [1, 2, 3], "b": 1})
grper = pd.Grouper(key="a")
x = df.groupby(grper)
grper.groups
This returns the groups right now and wouldn't work anymore?
There was a problem hiding this comment.
For me this raises AttributeError on main
There was a problem hiding this comment.
Ah I wasn't on the newest commit, this changed in 385a667
Was this intentional? Should add a whatsnew then, since this is technically user facing
There was a problem hiding this comment.
oh your right, darn. i guess will have to revert part of #51145 and do that+this as a deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.