CLN: Remove redundant initialization from Int64Index and Float64Index constructor #5117
+6
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Int64Index had duplicate code under a branch plus both were looking for scalar data errors handled in `_coerce_to_ndarray` anyways.
|
this looks ok |
|
@jreback changes Float64Index too - okay? |
|
prob was the same issue |
jtratner
added a commit
that referenced
this pull request
Oct 5, 2013
CLN: Remove redundant initialization from Int64Index and Float64Index constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int64Indexrepeated itself and actually reconstructed an ndarray twice when passed in data was an iterable. This simplifies it down but does not actually change any behavior. (you'll see that there was basically exactly the same code twice)