BUG: Add is_any_real_numeric_dtype to solve discrepancy between Index.is_numeric() and is_numeric_dtype()
#51160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
changed the title
is_any_real_numeric_dtype to solve discrepancy between Index.is_numeric() and is_numeric_dtype()
ABCPAN-rank
changed the title
is_any_real_numeric_dtype to solve discrepancy between Index.is_numeric() and is_numeric_dtype()is_any_real_numeric_dtype to solve discrepancy between Index.is_numeric() and is_numeric_dtype()
|
Could you check the failing builds? |
phofl
reviewed
Feb 5, 2023
phofl
reviewed
Feb 5, 2023
phofl
reviewed
Feb 6, 2023
mroeschke
reviewed
Feb 6, 2023
mroeschke
reviewed
Feb 6, 2023
| @@ -1219,9 +1219,9 @@ def is_numeric_dtype(arr_or_dtype) -> bool: | |||
| ) | |||
|
|
|||
|
|
|||
| def is_any_numeric_dtype(arr_or_dtype) -> bool: | |||
| def is_any_real_numeric_dtype(arr_or_dtype) -> bool: | |||
There was a problem hiding this comment.
@phofl on the off chance someone is actually using this, maybe it's safer if we make an alias is_any_real_numeric_dtype = is_any_numeric_dtype the "public" version?
There was a problem hiding this comment.
It was only added a couple of days ago, it's especially in no release yet, so I think we are good.
There was a problem hiding this comment.
Ah okay gotcha. Fine to change then
When i solve conflict , I did wrong.
phofl
approved these changes
Feb 7, 2023
|
thx @ABCPAN-rank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.is_numeric()andis_numeric_dtypeforboolIndex#51152doc/source/whatsnew/v2.0.0.rstfile if fixing a bug or adding a new feature.