Skip to content

BUG: catch decimal.InvalidOperation exception from dateutil #51157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2023
Merged

BUG: catch decimal.InvalidOperation exception from dateutil #51157

merged 3 commits into from
Feb 7, 2023

Conversation

kcaashish
Copy link
Contributor

@MarcoGorelli MarcoGorelli self-requested a review February 5, 2023 17:49
@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Feb 6, 2023
MarcoGorelli
MarcoGorelli suggested changes Feb 6, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kcaashish ! This is off to a good start

MarcoGorelli
MarcoGorelli approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks @kcaashish ! lgtm pending green

@kcaashish
Copy link
Contributor Author

Thank you!

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Feb 7, 2023
@MarcoGorelli MarcoGorelli added Bug Datetime Datetime data dtype and removed Error Reporting Incorrect or improved errors from pandas labels Feb 7, 2023
@MarcoGorelli MarcoGorelli requested review from jbrockmendel and removed request for jbrockmendel February 7, 2023 14:08
@MarcoGorelli MarcoGorelli merged commit 11d856f into pandas-dev:main Feb 7, 2023
@kcaashish kcaashish deleted the du-parse-fix branch February 7, 2023 14:36
jbrockmendel
jbrockmendel reviewed Feb 7, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Bug Datetime Datetime data dtype
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

BUG: to_datetime with errors coerce throws InvalidOperation decimal.DivisionImpossible
4 participants
@kcaashish @jbrockmendel @MarcoGorelli @mroeschke