Skip to content

REF: avoid passing silently-ignored kwargs to Resampler #51149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2023
Merged

REF: avoid passing silently-ignored kwargs to Resampler #51149

merged 3 commits into from
Feb 4, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Refactor Internal refactoring of code Resample resample method labels Feb 3, 2023
@phofl phofl modified the milestones: No action, 1.5.4, 2.0 Feb 4, 2023
@phofl phofl merged commit 605d446 into pandas-dev:main Feb 4, 2023
@phofl
Copy link
Member

phofl commented Feb 4, 2023

thx @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-rs-shallow_copy branch February 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Resample resample method
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @phofl @mroeschke