CLN: Use fixture dtype_backend in nullable tests #51129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 3, 2023
| @@ -912,7 +912,6 @@ def test_to_numeric_use_nullable_dtypes_already_nullable(dtype): | |||
| @pytest.mark.parametrize( | |||
| "use_nullable_dtypes, dtype", [(True, "Float64"), (False, "float64")] | |||
| ) | |||
| @pytest.mark.parametrize("dtype_backend", ["pandas", "pyarrow"]) | |||
| def test_to_numeric_use_nullable_dtypes_error( | |||
There was a problem hiding this comment.
I think the pytest.importorskip("pyarrow") can be removed within the test now
mroeschke
reviewed
Feb 3, 2023
| @@ -640,6 +641,7 @@ def test_use_nullable_dtypes(self, engine, request): | |||
| expected = expected.drop("c", axis=1) | |||
| tm.assert_frame_equal(result2, expected) | |||
|
|
|||
| @pytest.mark.skipif(pa_version_under6p0, reason="minimum pyarrow not installed") | |||
There was a problem hiding this comment.
Doesn't engine already do a similar skipif?
There was a problem hiding this comment.
I thought so as well, but it was failing locally without pyarrow
There was a problem hiding this comment.
Ah sorry, actually it's only skipped for pyarrow engine but it is imported for both engines, e.g. the test will fail if fast parquet engine is used
mroeschke
reviewed
Feb 3, 2023
| @@ -591,6 +591,7 @@ def test_write_column_index_nonstring(self, pa): | |||
| msg = r"parquet must have string column names" | |||
| self.check_error_on_write(df, engine, ValueError, msg) | |||
|
|
|||
| @pytest.mark.skipif(pa_version_under6p0, reason="minimum pyarrow not installed") | |||
mroeschke
approved these changes
Feb 4, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.