-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: remove inplace usage from docstring examples #51124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me pending green
Removed 2 additional examples advertising copy=False |
This reverts commit 201f877.
is using if so, no objections, lgtm |
copy=False will be the new default with CoW. copy=True can be done through |
makes sense, thanks! anything else you wanted to get in here or good to merge? |
Nothing I can think of right now, so good to go I think |
let's ship it, thanks @phofl ! |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Removes the inplace=True usage examples from the docstring examples.