DEPR: Remove NumericIndex from indexes/range.py #51095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # type "Type[RangeIndex]" in supertype "Index" | ||
| @cache_readonly | ||
| def _constructor(self) -> type[NumericIndex]: # type: ignore[override] | ||
| def _constructor(self) -> type[Index]: | ||
| """return the class to use for construction""" | ||
| return NumericIndex |
There was a problem hiding this comment.
this is going to be updated to return Index before long?
There was a problem hiding this comment.
Yes, couldn't do it here because there is some issue with empty indexes (Index([]) and NumericIndex([]) are not the same).
topper-123
force-pushed
the
remove_NumericIndex_from_RangeIndex
branch
from
c546c1b to
2c7cb6f
Compare
phofl
approved these changes
Feb 1, 2023
|
thx @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
NumericIndexfrompandas/core/indexes/range.py. There are a few instances left that will be removed whenNumericIndexis removed proper.xref #42717.