-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: can't round-trip non-nano Timestamp #51087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoGorelli
merged 26 commits into
pandas-dev:main
from
MarcoGorelli:timestamp-roundtrip
Feb 9, 2023
Merged
Changes from 7 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d94ef37
add test
9a57c9a
default to ns
30bb898
wip
648037e
fixup tests
bada089
fixup tests
c05cf4e
Merge remote-tracking branch 'upstream/main' into timestamp-roundtrip
f9a4efc
:truck: out_reso -> reso; explicit None check
72d9045
Merge remote-tracking branch 'upstream/main' into timestamp-roundtrip
6a5e5f1
keep test mixed
dd37781
Merge remote-tracking branch 'upstream/main' into timestamp-roundtrip
f5abfeb
fixup
00b8816
wip
fc11352
can undo change now
65e0f44
fixup
b26e3c9
Merge remote-tracking branch 'upstream/main' into timestamp-roundtrip
82a80db
remove debug stmt
b71f629
fix logic
f749d4d
fix precision calculation
7d27066
noop
de66535
exhaust match
b692b03
Merge remote-tracking branch 'upstream/main' into timestamp-roundtrip
f3205b2
use libc log10, reso -> out_reso, periods_per_second
27fd951
uncomment on:
3b54d5e
Revert "uncomment on:"
19717cb
Merge remote-tracking branch 'upstream/main' into timestamp-roundtrip
1f5fa7a
set unit to ns if None
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we assign unit="ns" here since we pass it to cast_from_unit below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, good one, thanks