Skip to content

BUG: allow plot, boxplot, hist and completion on GroupBy objects #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 4, 2013
Merged

BUG: allow plot, boxplot, hist and completion on GroupBy objects #5105

merged 3 commits into from
Oct 4, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Oct 4, 2013

closes #5102

also fixes extra plots created by groupby plotting (couldn't find an issue), now there's a test that ensures that groupby only plots the number of axes/figures it's supposed to
removes an unused internal groupby parameter

@ghost ghost assigned cpcloud Oct 4, 2013
@cpcloud
Copy link
Member Author

cpcloud commented Oct 4, 2013

@jreback @jtratner thoughts?

@jreback
Copy link
Contributor

jreback commented Oct 4, 2013

should those plot tests be marked slow?

@@ -2728,6 +2727,85 @@ def test_groupby_whitelist(self):
with tm.assertRaisesRegexp(AttributeError, msg):
getattr(gb, bl)

def test_series_groupby_plotting_nominally_works(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is pretty quick so not marking as @slow

@cpcloud
Copy link
Member Author

cpcloud commented Oct 4, 2013

alright this is ready to go pending review, @jreback @jtratner ?

@jreback
Copy link
Contributor

jreback commented Oct 4, 2013

good

maybe put a tab complete example for say frames in docs as well (basics?) later if u can

@cpcloud
Copy link
Member Author

cpcloud commented Oct 4, 2013

done ... i put in 10min.rst since tab completion is so useful that people should know about it as soon as they start using pandas.

@jreback
Copy link
Contributor

jreback commented Oct 4, 2013

gre8...looks fine to me

cpcloud added a commit that referenced this pull request Oct 4, 2013
BUG: allow plot, boxplot, hist and completion on GroupBy objects
@cpcloud cpcloud merged commit 7a886b5 into pandas-dev:master Oct 4, 2013
@cpcloud cpcloud deleted the enable-groupby-plot-and-completion branch October 4, 2013 17:19
@cpcloud
Copy link
Member Author

cpcloud commented Oct 4, 2013

@nehalecky there you go :)

@nehalecky
Copy link
Contributor

Grand, thank you so much @cpcloud, this works perfectly! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: in .groupby.SeriesGroupBy plot not accessible?
3 participants