Skip to content

PERF: avoid unnecessary cast in Groupby.std with Float64 #51021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2023
Merged

PERF: avoid unnecessary cast in Groupby.std with Float64 #51021

merged 1 commit into from
Jan 27, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

phofl
phofl approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for catching

@phofl phofl added Groupby NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Jan 27, 2023
@phofl phofl added this to the 2.0 milestone Jan 27, 2023
@phofl phofl merged commit 57c6533 into pandas-dev:main Jan 27, 2023
@jbrockmendel jbrockmendel deleted the perf-gb-nullable-std branch January 27, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Groupby NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @phofl