BUG: fix PeriodIndex join with DatetimeIndex stack overflow #5101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| 'can only call with other PeriodIndex-ed ' | ||
| 'objects'): | ||
| for join in joins: | ||
| df.columns.join(s.index, how=join) |
There was a problem hiding this comment.
should swap the loop and with here
| return self.values.copy() | ||
| else: # pragma: no cover | ||
| raise ValueError('Cannot cast PeriodIndex to dtype %s' % dtype) | ||
| return Index(self.values.copy(), dtype) |
There was a problem hiding this comment.
why copy instead of view here? I know that's what was there before, just strange.
There was a problem hiding this comment.
was just about to ask that actually...@jreback?
|
looks good to me |
|
ok too |
cpcloud
added a commit
that referenced
this pull request
Oct 4, 2013
…overflow BUG: fix PeriodIndex join with DatetimeIndex stack overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3899.