Skip to content

BUG: to_coo raising Systemerror for EA #51007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v2.0.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1154,7 +1154,7 @@ Sparse
^^^^^^
- Bug in :meth:`Series.astype` when converting a ``SparseDtype`` with ``datetime64[ns]`` subtype to ``int64`` dtype raising, inconsistent with the non-sparse behavior (:issue:`49631`,:issue:`50087`)
- Bug in :meth:`Series.astype` when converting a from ``datetime64[ns]`` to ``Sparse[datetime64[ns]]`` incorrectly raising (:issue:`50082`)
-
- Bug in :meth:`Series.sparse.to_coo` raising ``SystemError`` when :class:`MultiIndex` contains a ``ExtensionArray`` (:issue:`50996`)

ExtensionArray
^^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/sparse/scipy_sparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def _levels_to_axis(

else:
levels_values = lib.fast_zip(
[ss.index.get_level_values(lvl).values for lvl in levels]
[ss.index.get_level_values(lvl).to_numpy() for lvl in levels]
)
codes, ax_labels = factorize(levels_values, sort=sort_labels)
ax_coords = codes[valid_ilocs]
Expand Down
19 changes: 19 additions & 0 deletions pandas/tests/arrays/sparse/test_accessor.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,25 @@ def test_to_coo_nonzero_fill_val_raises(self, fill_value):
with pytest.raises(ValueError, match="fill value must be 0"):
df.sparse.to_coo()

@td.skip_if_no_scipy
def test_to_coo_midx_categorical(self):
# GH#50996
import scipy.sparse

midx = pd.MultiIndex.from_arrays(
[
pd.CategoricalIndex(list("ab"), name="x"),
pd.CategoricalIndex([0, 1], name="y"),
]
)

ser = pd.Series(1, index=midx, dtype="Sparse[int]")
result = ser.sparse.to_coo(row_levels=["x"], column_levels=["y"])[0]
expected = scipy.sparse.coo_matrix(
(np.array([1, 1]), (np.array([0, 1]), np.array([0, 1]))), shape=(2, 2)
)
assert (result != expected).nnz == 0

def test_to_dense(self):
df = pd.DataFrame(
{
Expand Down