Skip to content

CI: Test numpy 1.24 on 3.11 build #51006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 9, 2023
Merged

CI: Test numpy 1.24 on 3.11 build #51006

merged 19 commits into from
Feb 9, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 27, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added the CI Continuous Integration label Jan 27, 2023
@lithomas1
Copy link
Member

lithomas1 commented Jan 27, 2023 •
edited
Loading

Why don't we try unpinning numpy on 3.11 instead? That build has no numba IIRC.

@phofl
Copy link
Member Author

phofl commented Jan 27, 2023

Hm did not consider this, thanks for pointing it out. Makes sense to me

@phofl phofl changed the title CI: Add complete build with 1.24 numpy CI: Test numpy 1.24 on 3.11 build Jan 27, 2023
@phofl
Copy link
Member Author

phofl commented Feb 6, 2023

cc @mroeschke this is ready for a review now, not sure if we want to leave all the ignores in...

mroeschke
mroeschke reviewed Feb 6, 2023
View reviewed changes
mroeschke
mroeschke reviewed Feb 6, 2023
View reviewed changes
pandas/tests/series/test_constructors.py
@@ -804,7 +804,7 @@ def test_constructor_floating_data_int_dtype(self, frame_or_series):
# Long-standing behavior (for Series, new in 2.0 for DataFrame)
# has been to ignore the dtype on these;
# not clear if this is what we want long-term
expected = frame_or_series(arr)
# expected = frame_or_series(arr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these supposed to be commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they were unused, but the comment above is a bit confusing, that’s why I did not delete them
Outright

mroeschke
mroeschke reviewed Feb 6, 2023
View reviewed changes
pandas/core/arrays/masked.py Outdated
@@ -428,10 +428,14 @@ def to_numpy(
"for this dtype."
)
# don't pass copy to astype -> always need a copy since we are mutating
data = self._data.astype(dtype)
with warnings.catch_warnings():
warnings.filterwarnings("ignore")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to now what type of warnings these warnings.filterwarnings("ignore") are

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All runtime warnings iirc, but can add

@mroeschke
Copy link
Member

not sure if we want to leave all the ignores in

If there are any deprecation or future warnings those should be fixed

@phofl
Copy link
Member Author

phofl commented Feb 9, 2023

We are only filtering RuntimeWarnings now.

@phofl phofl added this to the 2.0 milestone Feb 9, 2023
@mroeschke
Copy link
Member

Were any of the RuntimeWarnings addressable, or were they specific to the data being passed?

@phofl
Copy link
Member Author

phofl commented Feb 9, 2023

All data dependent.

@mroeschke mroeschke merged commit 5be45c2 into pandas-dev:main Feb 9, 2023
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the ci_new_numpy branch February 9, 2023 17:56
@mroeschke
Copy link
Member

I think these tests are failing due to numpy being unpinned here

 FAILED pandas/tests/plotting/test_series.py::TestSeriesPlots::test_bar_log - AssertionError: numpy array are different

numpy array values are different (16.66667 %)
[left]:  [0.09999999999999999, 1.0, 10.0, 100.0, 1000.0, 10000.0]
[right]: [0.1, 1.0, 10.0, 100.0, 1000.0, 10000.0]
FAILED pandas/tests/plotting/frame/test_frame_subplots.py::TestDataFramePlotsSubplots::test_bar_log_no_subplots - AssertionError: numpy array are different

numpy array values are different (25.0 %)
[left]:  [0.09999999999999999, 1.0, 10.0, 100.0]
[right]: [0.1, 1.0, 10.0, 100.0]
FAILED pandas/tests/plotting/frame/test_frame_subplots.py::TestDataFramePlotsSubplots::test_bar_log_subplots - AssertionError: numpy array are different

numpy array values are different (16.66667 %)
[left]:  [0.09999999999999999, 1.0, 10.0, 100.0, 1000.0, 10000.0]
[right]: [0.1, 1.0, 10.0, 100.0, 1000.0, 10000.0]

@mroeschke mroeschke mentioned this pull request Feb 10, 2023
Merged
@phofl
Copy link
Member Author

phofl commented Feb 10, 2023 •
edited
Loading

Yikes this is weird, I xfailed them but this build started failing because the tests were passing again, so I removed it…

@rebecca-palmer rebecca-palmer mentioned this pull request Feb 15, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @lithomas1 @mroeschke