Skip to content

PERF: conditionally mark xfails as slow #50999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2023
Merged

PERF: conditionally mark xfails as slow #50999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions pandas/tests/extension/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,12 @@ def test_accumulate_series(self, data, all_numeric_accumulations, skipna, reques
)

if all_numeric_accumulations != "cumsum" or pa_version_under9p0:
if request.config.option.skip_slow:
# equivalent to marking these cases with @pytest.mark.slow,
# these xfails take a long time to run because pytest
# renders the exception messages even when not showing them
pytest.skip("pyarrow xfail slow")

request.node.add_marker(
pytest.mark.xfail(
reason=f"{all_numeric_accumulations} not implemented",
Expand Down Expand Up @@ -770,7 +776,9 @@ class TestBaseIndex(base.BaseIndexTests):


class TestBaseInterface(base.BaseInterfaceTests):
@pytest.mark.xfail(reason="GH 45419: pyarrow.ChunkedArray does not support views.")
@pytest.mark.xfail(
reason="GH 45419: pyarrow.ChunkedArray does not support views.", run=False
)
def test_view(self, data):
super().test_view(data)

Expand Down Expand Up @@ -800,13 +808,17 @@ class TestBasePrinting(base.BasePrintingTests):


class TestBaseReshaping(base.BaseReshapingTests):
@pytest.mark.xfail(reason="GH 45419: pyarrow.ChunkedArray does not support views")
@pytest.mark.xfail(
reason="GH 45419: pyarrow.ChunkedArray does not support views", run=False
)
def test_transpose(self, data):
super().test_transpose(data)


class TestBaseSetitem(base.BaseSetitemTests):
@pytest.mark.xfail(reason="GH 45419: pyarrow.ChunkedArray does not support views")
@pytest.mark.xfail(
reason="GH 45419: pyarrow.ChunkedArray does not support views", run=False
)
def test_setitem_preserves_views(self, data):
super().test_setitem_preserves_views(data)

Expand Down